Issue 10536147: Adjust GC tracing: add a flag to ignore scavenger traces and print total GC time in verbose mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536147: Adjust GC tracing: add a flag to ignore scavenger traces and print total GC time in verbose mode. (Closed)

Created:
8 years, 6 months ago by ulan

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Adjust GC tracing: add a flag to ignore scavenger traces and print total GC time in verbose mode. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12267

Patch Set 2 : Rename the flag to trace_gc_ignore_scavenger #

Patch Set 3 : Fix PrintF to PrintPID #

Total comments: 4

Patch Set 4 : Address comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
M	src/flag-definitions.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1 2 3	6 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one comment). https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc File src/heap.cc (left): https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc#oldcode6879 src/heap.cc:6879: Can we have that empty ...

8 years, 4 months ago (2012-08-06 14:21:36 UTC) #2

ulan

8 years, 4 months ago (2012-08-06 14:28:15 UTC) #3

Thanks, addressed comments.

https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc
File src/heap.cc (left):

https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc#oldcode...
src/heap.cc:6879: 
On 2012/08/06 14:21:36, Michael Starzinger wrote:
> Can we have that empty newline back?

Done.

https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc#newcode551
src/heap.cc:551: if (FLAG_trace_incremental_marking &&
!FLAG_trace_gc_ignore_scavenger) {
On 2012/08/06 14:21:36, Michael Starzinger wrote:
> Actually, I would like to see that with --trace-incremental-marking, it is
> independent from --trace-gc.

Done.