Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 10536144: First pass at making Chrome support metro snap mode. It creates a fullscreen-alike mode that Chrome… (Closed)

Created:
8 years, 6 months ago by robertshield
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, jennb, ben+watch_chromium.org, tfarina, Dmitry Titov, jianli, dcheng, chrome-win8-eng_google.com
Visibility:
Public.

Description

First pass at making Chrome support metro snap mode. It creates a fullscreen-alike mode that Chrome may enter when in metro snap mode. This mode removes the chrome parts of Chrome as well as disabling the F11 key, while clamping Chrome to the size of the snap view portion of the screen. Identical to http://crrev.com/141723 except for minor fixes in browser_view.cc to compile on Aura. BUG=130623 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142074

Patch Set 1 #

Patch Set 2 : Remerged with HEAD, hope nothing shifted this time. #

Patch Set 3 : Merge fallout in browser_win.cc. Trying again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -30 lines) Patch
M chrome/app/chrome_command_ids.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 3 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 7 chunks +32 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/fullscreen_controller.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/fullscreen_controller.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 5 chunks +35 lines, -9 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 3 chunks +22 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 5 chunks +60 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertshield
Hi Scott, This patch is identical to https://chromiumcodereview.appspot.com/10446106/ save for a couple of fixes in ...
8 years, 6 months ago (2012-06-13 12:41:13 UTC) #1
sky
LGTM - next time make the first patch the original so it's easy for the ...
8 years, 6 months ago (2012-06-13 16:03:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10536144/1
8 years, 6 months ago (2012-06-13 16:47:43 UTC) #3
commit-bot: I haz the power
Try job failure for 10536144-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-13 18:10:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10536144/3006
8 years, 6 months ago (2012-06-14 01:04:59 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-14 02:44:57 UTC) #6
Change committed as 142074

Powered by Google App Engine
This is Rietveld 408576698