Make GetWebKitRootDirFilePath return correct dir on Android.

Make GetWebKitRootDirFilePath return correct dir on Android.

http://codereview.chromium.org/9433049 added a trick in
single_test_runner to pretend we have a chrome/ dir for
webkit_unit_tests. Now webkit layout test runs into the same problem, so
I change the implementation directly to make sure it returns correct dir
for both webkit_unit_tests and layout test.

BUG=webkit_unit_tests,layout test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142673

[John Knottenbelt, 2012-06-13 09:35:40]

LGTM. Thanks, Hao!

[bulach, 2012-06-13 09:56:14]

lgtm, thanks!

[commit-bot: I haz the power, 2012-06-13 11:38:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zhenghao@chromium.org/10536140/1

[commit-bot: I haz the power, 2012-06-13 11:38:54]

Presubmit check for 10536140-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit/support

[Hao Zheng, 2012-06-13 11:40:21]

Kent, please take a look at the webkit/support/ change. Thanks!

[tkent, 2012-06-14 04:23:39]

https://chromiumcodereview.appspot.com/10536140/diff/1/webkit/support/webkit_...
File webkit/support/webkit_support.cc (right):

https://chromiumcodereview.appspot.com/10536140/diff/1/webkit/support/webkit_...
webkit/support/webkit_support.cc:227: #else
How about simply changing the following line like...

if
(file_util::PathExists(basePath.Append(FILE_PATH_LITERAL("third_party/WebKit"))))
{

?
We don't need to add #if defined(OS_ANDROID) in this case.

[Hao Zheng, 2012-06-18 04:34:04]

http://codereview.chromium.org/10536140/diff/1/webkit/support/webkit_support.cc
File webkit/support/webkit_support.cc (right):

http://codereview.chromium.org/10536140/diff/1/webkit/support/webkit_support....
webkit/support/webkit_support.cc:227: #else
Good idea. Done.
On 2012/06/14 04:23:39, Kent Tamura wrote:
> How about simply changing the following line like...
> 
> if
>
(file_util::PathExists(basePath.Append(FILE_PATH_LITERAL("third_party/WebKit"))))
> {
> 
> ?
> We don't need to add #if defined(OS_ANDROID) in this case.

[tkent, 2012-06-18 04:35:09]

LGTM

[commit-bot: I haz the power, 2012-06-18 04:35:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zhenghao@chromium.org/10536140/9001

[commit-bot: I haz the power, 2012-06-18 05:53:58]

Change committed as 142673