Issue 10536134: Change timeouts for renderer and plugin hang detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536134: Change timeouts for renderer and plugin hang detection (Closed)

Created:
8 years, 6 months ago by scottmg

Modified:
8 years, 6 months ago

Reviewers:
jam, Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, jschuhuh%chromium.org_gtempaccount.com, jschuh, kareng_chromium.org, cpu_(ooo_6.6-7.5), eroman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change timeouts for renderer and plugin hang detection Some crash detection work points to the the renderer hang dialog coming up when it should be the plugin hung dialog. To see if this is the cause of elevated renderer crash rates, make the plugin timeout lower than the renderer temporarily. This will probably be reverted after testing. R=jam@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141819

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/browser_view_prefs.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm, but please link to a bug and add more description to the cl

8 years, 6 months ago (2012-06-13 00:58:48 UTC) #2

Ben Goodger (Google)

lgtm On Tue, Jun 12, 2012 at 6:02 PM, <scottmg@chromium.org> wrote: > +ben for OWNERS ...

8 years, 6 months ago (2012-06-13 01:39:32 UTC) #5

laforge

8 years, 6 months ago (2012-06-13 14:45:44 UTC) #6

Will the hung renderer plugin dialog block the hung renderer dialog?  If not, my
assumption would be that a 5 second window would not be enough time for a user
to react and they'd ultimately just continue to click to kill the renderer.

On 2012/06/13 01:39:32, Ben Goodger (Google) wrote:
> lgtm
> 
> On Tue, Jun 12, 2012 at 6:02 PM, <mailto:scottmg@chromium.org> wrote:
> 
> > +ben for OWNERS
> >
> >
>
https://chromiumcodereview.**appspot.com/10536134/%3Chttps://chromiumcoderevi...>
> >

Expand Messages | Collapse Messages