Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: tools/valgrind/chrome_tests.py

Issue 10536127: Do not retry the layout tests that produce unexpected results when running under Valgrind. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 ''' Runs various chrome tests through valgrind_test.py.''' 6 ''' Runs various chrome tests through valgrind_test.py.'''
7 7
8 import glob 8 import glob
9 import logging 9 import logging
10 import optparse 10 import optparse
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 os.remove(f) 381 os.remove(f)
382 else: 382 else:
383 os.makedirs(out_dir) 383 os.makedirs(out_dir)
384 script = os.path.join(self._source_dir, "webkit", "tools", "layout_tests", 384 script = os.path.join(self._source_dir, "webkit", "tools", "layout_tests",
385 "run_webkit_tests.py") 385 "run_webkit_tests.py")
386 script_cmd = ["python", script, "-v", 386 script_cmd = ["python", script, "-v",
387 "--run-singly", # run a separate DumpRenderTree for each test 387 "--run-singly", # run a separate DumpRenderTree for each test
388 "--fully-parallel", 388 "--fully-parallel",
389 "--time-out-ms=200000", 389 "--time-out-ms=200000",
390 "--noshow-results", 390 "--noshow-results",
391 "--no-retry-failures", # retrying takes too much time
391 "--nocheck-sys-deps"] 392 "--nocheck-sys-deps"]
392 # Pass build mode to run_webkit_tests.py. We aren't passed it directly, 393 # Pass build mode to run_webkit_tests.py. We aren't passed it directly,
393 # so parse it out of build_dir. run_webkit_tests.py can only handle 394 # so parse it out of build_dir. run_webkit_tests.py can only handle
394 # the two values "Release" and "Debug". 395 # the two values "Release" and "Debug".
395 # TODO(Hercules): unify how all our scripts pass around build mode 396 # TODO(Hercules): unify how all our scripts pass around build mode
396 # (--mode / --target / --build_dir / --debug) 397 # (--mode / --target / --build_dir / --debug)
397 if self._options.build_dir.endswith("Debug"): 398 if self._options.build_dir.endswith("Debug"):
398 script_cmd.append("--debug"); 399 script_cmd.append("--debug");
399 if (chunk_size > 0): 400 if (chunk_size > 0):
400 script_cmd.append("--run-chunk=%d:%d" % (chunk_num, chunk_size)) 401 script_cmd.append("--run-chunk=%d:%d" % (chunk_num, chunk_size))
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 554
554 for t in options.test: 555 for t in options.test:
555 tests = ChromeTests(options, args, t) 556 tests = ChromeTests(options, args, t)
556 ret = tests.Run() 557 ret = tests.Run()
557 if ret: return ret 558 if ret: return ret
558 return 0 559 return 0
559 560
560 561
561 if __name__ == "__main__": 562 if __name__ == "__main__":
562 sys.exit(_main()) 563 sys.exit(_main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698