Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 10536122: Ensure GpuVideoDecoder satisfies outstanding reads before firing callback indicating it is reset. (Closed)

Created:
8 years, 6 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, Pawel Osciak
Visibility:
Public.

Description

Ensure GpuVideoDecoder satisfies outstanding reads before firing callback indicating it is reset. Previously GVD would post the fake frame to VideoRendererBase, but fire the callback without waiting for VRB to process the frame. Now the callback is posted to the same loop so VRB is guaranteed to see the frame before VRB::OnDecoderFlushDone() DCHECKs that !pending_read_. TEST=closing a tab playing HW-accelerated video no longer DCHECKs in VRB::OnDecoderFlushDone. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ami GONE FROM CHROMIUM
acolwell: please review. posciak: FYI.
8 years, 6 months ago (2012-06-12 18:21:43 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
8 years, 6 months ago (2012-06-12 20:17:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10536122/1
8 years, 6 months ago (2012-06-12 20:19:14 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 21:46:13 UTC) #4
Change committed as 141746

Powered by Google App Engine
This is Rietveld 408576698