Issue 10536108: When the user highlights all or part of a link, don't show "Go to <URL>" if that would navigate to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536108: When the user highlights all or part of a link, don't show "Go to <URL>" if that would navigate to … (Closed)

Created:
8 years, 6 months ago by Peter Kasting

Modified:
8 years, 6 months ago

Reviewers:
tfarina

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

When the user highlights all or part of a link, don't show "Go to <URL>" if that would navigate to the same place as the link itself, as this is redundant. BUG=112768 TEST=Go to a bug with a link; highlight the link (or the link without "http://" and/or the trailing slash), right-click, verify there's no "go to" context menu item. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141684

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/tab_contents/render_view_context_menu.cc	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

8 years, 6 months ago (2012-06-12 17:13:58 UTC) #2

LGTM.

Thanks for this fix Peter.

http://codereview.chromium.org/10536108/diff/1/chrome/browser/tab_contents/re...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/10536108/diff/1/chrome/browser/tab_contents/re...
chrome/browser/tab_contents/render_view_context_menu.cc:920: if
((selection_navigation_url_ != params_.link_url) &&
I verified this works.

Expand Messages | Collapse Messages