Avoid crash in trying to access profile while shutting down.

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 23092ac59afe0b9100e439311850e8d4b0b1bcbc..65bda1ee2fd5c74c09e3a1b2dd9faccf930997b4 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -3904,7 +3904,8 @@ void Browser::Observe(int type,
       if (pref_name == prefs::kPrintingEnabled) {
         UpdatePrintingState(GetContentRestrictionsForSelectedTab());
       } else if (pref_name == prefs::kInstantEnabled) {
-        if (!InstantController::IsEnabled(profile())) {
+        if (browser_shutdown::ShuttingDownWithoutClosingBrowsers() ||

[Jói, 2012/06/11 22:44:47]

Don't you want the inverse condition?

[sreeram, 2012/06/11 22:53:03]

No. If we are shutting down, the first clause returns true, so we don't check
the second clause (which is the one that uses profile and crashes). We'll then
delete the InstantController object, which is fine since we are shutting down.

In the normal case, the first clause returns false, and things behave as before.

+            !InstantController::IsEnabled(profile())) {
           if (instant()) {
             instant()->DestroyPreviewContents();
             instant_.reset();