Make Intl.message static

tests/lib/i18n/intl_message_test.dart

Index: tests/lib/i18n/intl_message_test.dart
===================================================================
--- tests/lib/i18n/intl_message_test.dart	(revision 8515)
+++ tests/lib/i18n/intl_message_test.dart	(working copy)
@@ -19,22 +19,20 @@
 }
 
 main() {
-  Intl intl = new Intl();
-
   test('Trivial Message', () {
-    hello() => intl.message('Hello, world!',
+    hello() => Intl.message('Hello, world!',
         desc: 'hello world string');
     expect(hello(), equals('Hello, world!'));
   });
 
   test('Message with one parameter', () {
-    lucky(number) => intl.message('Your lucky number is $number',
+    lucky(number) => Intl.message('Your lucky number is $number',
         desc: 'number str', examples: {'number': 2});
     expect(lucky(3), equals('Your lucky number is 3'));
   });
 
   test('Message with multiple plural cases (whole message)', () {
-    emails(number) => intl.message(
+    emails(number) => Intl.message(
         Intl.plural(number,
           {'0': 'There are no emails left.',
            '1': 'There is one email left.',
@@ -47,7 +45,7 @@
   });
 
   test('Message with multiple plural cases (partial message)', () {
-    emails(number) => intl.message(
+    emails(number) => Intl.message(
       "There ${Intl.plural(number,
         {'0': 'are',
          '1': 'is',
@@ -60,7 +58,7 @@
   });
 
   test('Message with dictionary parameter', () {
-    hello(dict) => intl.message(
+    hello(dict) => Intl.message(
         "Hello, my name is ${dict['first']} ${dict['last']}",
         desc: "States a person's name.",
         examples: {'first': 'Ford', 'last': 'Prefect'});
@@ -69,11 +67,23 @@
   });
 
   test('Message with object parameter', () {
-    hello(person) => intl.message(
+    hello(person) => Intl.message(
         "Hello, my name is ${person.firstName} ${person.lastName}.",
         desc: "States a person's name.",
         examples: {'first': 'Ford', 'last' : 'Prefect'});
     var ford = new Person('Ford', 'Prefect');
     expect(hello(ford), equals('Hello, my name is Ford Prefect.'));
   });
+
+  test('WithLocale test', () {
+    hello() => Intl.message('Hello, world!',
+        desc: 'hello world string');
+    expect(Intl.withLocale('en-US', () => hello()), equals('Hello, world!'));

[Alan Knight, 2012/06/13 00:52:32]

But this doesn't actually test that the locale can be different. We can test
that, by writing e.g.
  Intl.message("The current locale is ${getCurrentLocale()}", ... } and then
calling withLocale('de_DE') and verify that that's the locale it sees.
But right now I don't see any way for code to access the _locale that's in Intl.

[Emily Fortuna, 2012/06/13 01:27:48]

_locale is hidden, and I was planning on testing the *effect* of the locale once
we're using translated Strings. How can we test this currently? Unless we want
to break up "withLocale" into two functions, and test that the current locale is
set to the anticipated locale before calling withLocale1 and withLocale2, we're
not going to be able to test state that's changed and then restored in
withLocale.

[Alan Knight, 2012/06/13 01:34:58]

test('withLocale actually does something', () {
    hello() => Intl.message('locale=${getCurrentLocale())', desc: 'What is the
current locale'));
    expect(hello(), equals("locale = en_US"));
    withLocale('de_DE', () {
       expect(hello(), equals("locale = de_DE"))});
    expect(hello(),equals("locale = en_US"));
});

But this requires us to have some mechanism by which code can ask what the
current locale is.

+  });
+
+  test('Test passing locale', () {
+    hello(a_locale) => Intl.message('Hello, world!',
+        desc: 'hello world string', locale: a_locale);
+    expect(hello('en-US'), equals('Hello, world!'));
+  });
 }