Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10536096: Add code comment to ia32 disassembly as well, bug fix new ia32 compiler, remove use of TMP register… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 8552)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -1164,23 +1164,47 @@
LoadVMFieldComp(Value* value,
intptr_t offset_in_bytes,
const AbstractType& type)
- : offset_in_bytes_(offset_in_bytes), type_(type) {
+ : offset_in_bytes_(offset_in_bytes),
+ type_(type),
+ original_(NULL),
+ class_ids_(NULL) {
ASSERT(value != NULL);
ASSERT(type.IsZoneHandle()); // May be null if field is not an instance.
inputs_[0] = value;
}
+ LoadVMFieldComp(Value* value,
+ intptr_t offset_in_bytes,
+ const AbstractType& type,
+ InstanceCallComp* original,
+ ZoneGrowableArray<intptr_t>* class_ids)
+ : offset_in_bytes_(offset_in_bytes),
+ type_(type),
+ original_(original),
+ class_ids_(class_ids) {
+ ASSERT(value != NULL);
+ ASSERT(type.IsZoneHandle()); // May be null if field is not an instance.
+ ASSERT(original != NULL);
+ ASSERT(class_ids != NULL);
+ inputs_[0] = value;
+ }
+
DECLARE_COMPUTATION(LoadVMField)
Value* value() const { return inputs_[0]; }
intptr_t offset_in_bytes() const { return offset_in_bytes_; }
const AbstractType& type() const { return type_; }
+ const ZoneGrowableArray<intptr_t>* class_ids() const { return class_ids_; }
+ const InstanceCallComp* original() const { return original_; }
virtual void PrintOperandsTo(BufferFormatter* f) const;
private:
const intptr_t offset_in_bytes_;
const AbstractType& type_;
+ const InstanceCallComp* original_; // For optimizations.
+ // If non-NULL, the instruction is valid only for the class ids listed.
+ const ZoneGrowableArray<intptr_t>* class_ids_;
DISALLOW_COPY_AND_ASSIGN(LoadVMFieldComp);
};
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698