Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10536086: Add stack check in loops so that loops can be stopped. Optimize relational operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.h ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 8493)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -176,12 +176,12 @@
static bool HasOneTarget(const ICData& ic_data) {
ASSERT(ic_data.NumberOfChecks() > 0);
Function& prev_target = Function::Handle();
- Class& cls = Class::Handle();
- ic_data.GetOneClassCheckAt(0, &cls, &prev_target);
+ GrowableArray<const Class*> classes;
+ ic_data.GetCheckAt(0, &classes, &prev_target);
ASSERT(!prev_target.IsNull());
Function& target = Function::Handle();
for (intptr_t i = 1; i < ic_data.NumberOfChecks(); i++) {
- ic_data.GetOneClassCheckAt(i, &cls, &target);
+ ic_data.GetCheckAt(i, &classes, &target);
ASSERT(!target.IsNull());
if (prev_target.raw() != target.raw()) {
return false;
@@ -335,7 +335,9 @@
const ICData& ic_data = *comp->ic_data();
if (ic_data.NumberOfChecks() == 0) return;
- if (!HasOneTarget(ic_data)) return;
+ // TODO(vegorov): Add multiple receiver type support.
+ if (ic_data.NumberOfChecks() != 1) return;
+ ASSERT(HasOneTarget(ic_data));
Function& target = Function::Handle();
Class& cls = Class::Handle();
@@ -350,6 +352,23 @@
}
+void FlowGraphOptimizer::VisitRelationalOp(RelationalOpComp* comp) {
+ if (!comp->HasICData()) return;
+
+ const ICData& ic_data = *comp->ic_data();
+ if (ic_data.NumberOfChecks() == 0) return;
+ // TODO(srdjan): Add multiple receiver type support.
+ if (ic_data.NumberOfChecks() != 1) return;
+ ASSERT(HasOneTarget(ic_data));
+
+ if (HasTwoSmi(ic_data)) {
+ comp->set_operands_class_id(kSmi);
+ } else if (HasTwoDouble(ic_data)) {
+ comp->set_operands_class_id(kDouble);
+ }
+}
+
+
void FlowGraphOptimizer::VisitDo(DoInstr* instr) {
instr->computation()->Accept(this);
}
« no previous file with comments | « runtime/vm/flow_graph_optimizer.h ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698