Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 10536084: Add a warning when developing an extension that uses old manifest version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blonk Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/extensions/extensions.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 'use strict'; 6 'use strict';
7 7
8 /** 8 /**
9 * A lookup helper function to find the first node that has an id (starting 9 * A lookup helper function to find the first node that has an id (starting
10 * at |node| and going up the parent chain). 10 * at |node| and going up the parent chain).
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 list.appendChild(document.createElement('li')).innerText = warning; 253 list.appendChild(document.createElement('li')).innerText = warning;
254 }); 254 });
255 } 255 }
256 256
257 // The install warnings. 257 // The install warnings.
258 if (extension.installWarnings) { 258 if (extension.installWarnings) {
259 var panel = node.querySelector('.install-warnings'); 259 var panel = node.querySelector('.install-warnings');
260 panel.hidden = false; 260 panel.hidden = false;
261 var list = panel.querySelector('ul'); 261 var list = panel.querySelector('ul');
262 extension.installWarnings.forEach(function(warning) { 262 extension.installWarnings.forEach(function(warning) {
263 list.appendChild(document.createElement('li')).innerText = warning; 263 var li = document.createElement('li');
264 li[warning.isHTML ? 'innerHTML' : 'innerText'] = warning.message;
265 list.appendChild(li);
264 }); 266 });
265 } 267 }
266 268
267 this.appendChild(node); 269 this.appendChild(node);
268 } 270 }
269 }; 271 };
270 272
271 return { 273 return {
272 ExtensionsList: ExtensionsList 274 ExtensionsList: ExtensionsList
273 }; 275 };
274 }); 276 });
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/extensions/extensions.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698