Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: tools/isolate/trace_child_process.py

Issue 10536078: Enable parallel tracing support on Dtrace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/isolate/trace_inputs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/trace_child_process.py
diff --git a/tools/isolate/trace_child_process.py b/tools/isolate/trace_child_process.py
index 07d9915c50c813656f812b42054d2fd1d60dead4..d026d5e4e644a20b7c1865c8e8dec2c88935806f 100755
--- a/tools/isolate/trace_child_process.py
+++ b/tools/isolate/trace_child_process.py
@@ -17,17 +17,12 @@ import sys
def main():
- cmd = sys.argv[1:]
- if sys.argv[1] == '--wait':
- cmd = cmd[1:]
- signal = 'Go!'
- value = sys.stdin.read(len(signal))
- assert value == signal
- sys.stdin.close()
+ cmd = sys.argv[2:]
# The reason os.execve() is not used is that we don't want the modules
# imported here to influence the executable being traced, so we need a fresh
# pid and need to fork.
+ # TODO(maruel): Use CreateProcess() on Windows and fork manually on OSX.
return subprocess.call(cmd)
« no previous file with comments | « no previous file | tools/isolate/trace_inputs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698