Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 10536075: Use proper anchor window in SimpleMessageBoxViews (Closed)

Created:
8 years, 6 months ago by oshima
Modified:
8 years, 6 months ago
Reviewers:
stevenjb, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Use proper anchor window in SimpleMessageBoxViews parent can be null. Instead, it should use the dialog's native view. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141296

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/views/simple_message_box_views.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
lgtm
8 years, 6 months ago (2012-06-08 19:27:07 UTC) #1
oshima
sky -> OWNERS
8 years, 6 months ago (2012-06-08 20:14:46 UTC) #2
sky
LGTM
8 years, 6 months ago (2012-06-08 20:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10536075/6001
8 years, 6 months ago (2012-06-08 20:59:09 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 21:57:44 UTC) #5
Change committed as 141296

Powered by Google App Engine
This is Rietveld 408576698