Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 10536070: Roll gyp 1409:1413 (Closed)

Created:
8 years, 6 months ago by Steve Block
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Roll gyp 1409:1413 r1410 Fix bug in ninja/msvs/scons generator when there's no default action. r1411 Make backends robust to rules and actions containing slashes r1412 ninja windows: support alternative entrypoints. r1413 Fix make backend to correctly handle rules with output files of the same name Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141254

Patch Set 1 #

Patch Set 2 : Added description of changes being rolled in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Steve Block
8 years, 6 months ago (2012-06-08 15:38:36 UTC) #1
Nico
Can you include a short summary of the changes in the roll, like so: http://svnsearch.org/svnsearch/repos/CHROMIUM/search?logMessage=roll%20gyp ...
8 years, 6 months ago (2012-06-08 15:40:48 UTC) #2
Steve Block
Added a description
8 years, 6 months ago (2012-06-08 15:48:04 UTC) #3
Steve Block
win_rel failure looks like flakiness
8 years, 6 months ago (2012-06-08 16:57:03 UTC) #4
Nico
lgtm
8 years, 6 months ago (2012-06-08 17:10:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10536070/6001
8 years, 6 months ago (2012-06-08 17:11:02 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 19:25:34 UTC) #7
Change committed as 141254

Powered by Google App Engine
This is Rietveld 408576698