Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Unified Diff: runtime/vm/code_generator.cc

Issue 10536067: Generate code for store buffer updates in open-coded object field stores. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: adjust filter conditions Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_generator.cc
diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc
index 42b0f13c4f34416fcc5bb89728ca89fb4bddc3a7..30b51e0d819e72fc5dc0fab611a26555a97d8304 100644
--- a/runtime/vm/code_generator.cc
+++ b/runtime/vm/code_generator.cc
@@ -1561,4 +1561,14 @@ RawCode* FunctionsCache::LookupCode(const String& function_name,
return Code::null();
}
+
+// Adds a pointer to the store buffer.
+// Arg0: pointer
+DEFINE_RUNTIME_ENTRY(StoreBuffer, 1) {
Ivan Posva 2012/06/08 14:39:55 This then would be StoreBuffer_Process.
+ ASSERT(arguments.Count() == kStoreBufferRuntimeEntry.argument_count());
+ RawObject* dest = arguments.At(0);
srdjan 2012/06/08 05:46:59 You may want to do Object::CheckedHandle so that y
cshapiro 2012/06/08 23:48:04 Unfortunately, I cannot. dest is not an object, i
+ uword ptr = reinterpret_cast<uword>(dest);
+ Isolate::Current()->store_buffer()->AddPointer(ptr);
siva 2012/06/08 17:26:01 isolate->store_buffer().... isolate is a param to
cshapiro 2012/06/08 23:48:04 Fixed.
+}
+
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698