Generate code for store buffer updates in open-coded object field stores.

runtime/vm/stub_code_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/assembler_macros.h"
 #include "vm/code_generator.h"
@@ skipping 647 matching lines @@
 
   if (FLAG_inline_alloc) {
     // Compute the size to be allocated, it is based on the array length
     // and it computed as:
     // RoundedAllocationSize((array_length * kwordSize) + sizeof(RawArray)).
     // Assert that length is a Smi.
     __ testl(EDX, Immediate(kSmiTagSize));
     if (FLAG_use_slow_path) {
       __ jmp(&slow_case);
     } else {
-      __ j(NOT_ZERO, &slow_case, Assembler::kNearJump);
+      __ j(NOT_ZERO, &slow_case);
     }
     __ movl(EDI, FieldAddress(CTX, Context::isolate_offset()));
     __ movl(EDI, Address(EDI, Isolate::heap_offset()));
     __ movl(EDI, Address(EDI, Heap::new_space_offset()));
 
     // Calculate and align allocation size.
     // Load new object start and calculate next object start.
     // ECX: array element type.
     // EDX: Array length as Smi.
     // EDI: Points to new space object.
     __ movl(EAX, Address(EDI, Scavenger::top_offset()));
     intptr_t fixed_size = sizeof(RawArray) + kObjectAlignment - 1;
     __ leal(EBX, Address(EDX, TIMES_2, fixed_size));  // EDX is Smi.
     ASSERT(kSmiTagShift == 1);
     __ andl(EBX, Immediate(-kObjectAlignment));
     __ leal(EBX, Address(EAX, EBX, TIMES_1, 0));
 
     // Check if the allocation fits into the remaining space.
     // EAX: potential new object start.
     // EBX: potential next object start.
     // ECX: array element type.
     // EDX: Array length as Smi.
     // EDI: Points to new space object.
     __ cmpl(EBX, Address(EDI, Scavenger::end_offset()));
-    __ j(ABOVE_EQUAL, &slow_case, Assembler::kNearJump);
+    __ j(ABOVE_EQUAL, &slow_case);
 
     // Successfully allocated the object(s), now update top to point to
     // next object start and initialize the object.
     // EAX: potential new object start.
     // EBX: potential next object start.
     // EDX: Array length as Smi.
     // EDI: Points to new space object.
     __ movl(Address(EDI, Scavenger::top_offset()), EBX);
     __ addl(EAX, Immediate(kHeapObjectTag));
 
     // EAX: new object start as a tagged pointer.
     // EBX: new object end address.
     // ECX: array element type.
     // EDX: Array length as Smi.
 
     // Store the type argument field.
-    __ StoreIntoObject(EAX,
-                       FieldAddress(EAX, Array::type_arguments_offset()),
-                       ECX);
+    __ StoreIntoObjectNoBarrier(
+        EAX,
+        FieldAddress(EAX, Array::type_arguments_offset()),
+        ECX);
 
     // Set the length field.
-    __ StoreIntoObject(EAX,
-                       FieldAddress(EAX, Array::length_offset()),
-                       EDX);
+    __ StoreIntoObjectNoBarrier(
+        EAX,
+        FieldAddress(EAX, Array::length_offset()),
+        EDX);
 
     // Calculate the size tag.
     // EAX: new object start as a tagged pointer.
     // EBX: new object end address.
     // EDX: Array length as Smi.
     {
       Label size_tag_overflow, done;
       __ leal(ECX, Address(EDX, TIMES_2, fixed_size));  // EDX is Smi.
       ASSERT(kSmiTagShift == 1);
       __ andl(ECX, Immediate(-kObjectAlignment));
@@ skipping 16 matching lines @@
     // EBX: new object end address.
     // EDX: Array length as Smi.
     __ leal(ECX, FieldAddress(EAX, Array::data_offset()));
     // ECX: iterator which initially points to the start of the variable
     // data area to be initialized.
     Label done;
     Label init_loop;
     __ Bind(&init_loop);
     __ cmpl(ECX, EBX);
     __ j(ABOVE_EQUAL, &done, Assembler::kNearJump);
+    // TODO(cshapiro): StoreIntoObjectNoBarrier
     __ movl(Address(ECX, 0), raw_null);
     __ addl(ECX, Immediate(kWordSize));
     __ jmp(&init_loop, Assembler::kNearJump);
     __ Bind(&done);
 
     // Done allocating and initializing the array.
     // EAX: new object.
     // EDX: Array length as Smi (preserved for the caller.)
     __ ret();
   }
@@ skipping 1133 matching lines @@
 // TOS + 2: instance.
 // TOS + 3: cache array.
 // Result in ECX: null -> not found, otherwise result (true or false).
 void StubCode::GenerateSubtype3TestCacheStub(Assembler* assembler) {
   GenerateSubtypeNTestCacheStub(assembler, 3);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32