Generate code for store buffer updates in open-coded object field stores.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 23 matching lines @@
   const intptr_t kTypeArgumentsOffset = 2 * kWordSize;
   const intptr_t kArrayLengthOffset = 1 * kWordSize;
   Label fall_through;
 
   // Compute the size to be allocated, it is based on the array length
   // and it computed as:
   // RoundedAllocationSize((array_length * kwordSize) + sizeof(RawArray)).
   __ movl(EDI, Address(ESP, kArrayLengthOffset));  // Array Length.
   // Assert that length is a Smi.
   __ testl(EDI, Immediate(kSmiTagSize));
-  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);
+  __ j(NOT_ZERO, &fall_through);
   __ cmpl(EDI, Immediate(0));
-  __ j(LESS, &fall_through, Assembler::kNearJump);
+  __ j(LESS, &fall_through);
   intptr_t fixed_size = sizeof(RawArray) + kObjectAlignment - 1;
   __ leal(EDI, Address(EDI, TIMES_2, fixed_size));  // EDI is a Smi.
   ASSERT(kSmiTagShift == 1);
   __ andl(EDI, Immediate(-kObjectAlignment));
 
   Isolate* isolate = Isolate::Current();
   Heap* heap = isolate->heap();
 
   // EDI: allocation size.
   __ movl(EAX, Address::Absolute(heap->TopAddress()));
   __ leal(EBX, Address(EAX, EDI, TIMES_1, 0));
 
   // Check if the allocation fits into the remaining space.
   // EAX: potential new object start.
   // EBX: potential next object start.
   // EDI: allocation size.
   __ cmpl(EBX, Address::Absolute(heap->EndAddress()));
-  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
+  __ j(ABOVE_EQUAL, &fall_through);
 
   // Successfully allocated the object(s), now update top to point to
   // next object start and initialize the object.
   __ movl(Address::Absolute(heap->TopAddress()), EBX);
   __ addl(EAX, Immediate(kHeapObjectTag));
 
   // Initialize the tags.
   // EAX: new object start as a tagged pointer.
   // EBX: new object end address.
   // EDI: allocation size.
@@ skipping 11 matching lines @@
     // Get the class index and insert it into the tags.
     const Class& cls = Class::Handle(isolate->object_store()->array_class());
     __ orl(EDI, Immediate(RawObject::ClassIdTag::encode(cls.id())));
     __ movl(FieldAddress(EAX, Array::tags_offset()), EDI);  // Tags.
   }
 
   // EAX: new object start as a tagged pointer.
   // EBX: new object end address.
   // Store the type argument field.
   __ movl(EDI, Address(ESP, kTypeArgumentsOffset));  // type argument.
-  __ StoreIntoObject(EAX,
-                     FieldAddress(EAX, Array::type_arguments_offset()),
-                     EDI);
+  __ StoreIntoObjectNoBarrier(EAX,
+                              FieldAddress(EAX, Array::type_arguments_offset()),
+                              EDI);
 
   // Set the length field.
   __ movl(EDI, Address(ESP, kArrayLengthOffset));  // Array Length.
-  __ StoreIntoObject(EAX, FieldAddress(EAX, Array::length_offset()), EDI);
+  __ StoreIntoObjectNoBarrier(EAX,
+                              FieldAddress(EAX, Array::length_offset()),
+                              EDI);
 
   // Initialize all array elements to raw_null.
   // EAX: new object start as a tagged pointer.
   // EBX: new object end address.
   // EDI: iterator which initially points to the start of the variable
   // data area to be initialized.
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
   __ leal(EDI, FieldAddress(EAX, sizeof(RawArray)));
   Label done;
@@ skipping 180 matching lines @@
 
   // Store backing array object in growable array object.
   __ movl(EBX, Address(ESP, kArrayOffset));  // data argument.
   __ StoreIntoObject(EAX,
                      FieldAddress(EAX, GrowableObjectArray::data_offset()),
                      EBX);
 
   // EAX: new growable array object start as a tagged pointer.
   // Store the type argument field in the growable array object.
   __ movl(EBX, Address(ESP, kTypeArgumentsOffset));  // type argument.
-  __ StoreIntoObject(EAX,
-                     FieldAddress(EAX,
-                                  GrowableObjectArray::type_arguments_offset()),
-                     EBX);
+  __ StoreIntoObjectNoBarrier(
+      EAX,
+      FieldAddress(EAX, GrowableObjectArray::type_arguments_offset()),
+      EBX);
 
   // Set the length field in the growable array object to 0.
   __ movl(FieldAddress(EAX, GrowableObjectArray::length_offset()),
           Immediate(0));
   __ ret();  // returns the newly allocated object in EAX.
 
   __ Bind(&fall_through);
   return false;
 }
 
@@ skipping 931 matching lines @@
   __ cmpl(EBX, FieldAddress(EAX, Array::length_offset()));  // Range check.
   __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
 
   // EBX is Smi, i.e, times 2.
   ASSERT(kSmiTagShift == 1);
   __ movl(EDI, FieldAddress(EAX, EBX, TIMES_2, sizeof(RawArray)));  // Result.
   const Immediate value = Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
   __ addl(EBX, value);  // _pos++.
   __ j(OVERFLOW, &fall_through, Assembler::kNearJump);
   __ movl(EAX, Address(ESP, + 1 * kWordSize));  // Receiver.
-  __ StoreIntoObject(EAX, FieldAddress(EAX, pos_offset), EBX);  // Store _pos.
+  __ StoreIntoObjectNoBarrier(EAX,
+                              FieldAddress(EAX, pos_offset),
+                              EBX);  // Store _pos.
   __ movl(EAX, EDI);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
 // Class 'FixedSizeArrayIterator':
 //   bool hasNext() {
 //     return _length > _pos;
@@ skipping 82 matching lines @@
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32