Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 10536065: Fix file handler executer setting wrong cache path permissions on drive. (Closed)

Created:
8 years, 6 months ago by tbarzic
Modified:
8 years, 6 months ago
Reviewers:
satorux1, hshi1
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix file handler executer setting wrong cache path permissions on drive. BUG=None TEST=RemoteFileSystem.RemoteMountPoint Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141220

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/chromeos/extensions/file_handler_util.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tbarzic
8 years, 6 months ago (2012-06-08 01:21:38 UTC) #1
hshi1
LGTM with the nit regarding the indentation in gdata_util.cc https://chromiumcodereview.appspot.com/10536065/diff/1/chrome/browser/chromeos/gdata/gdata_util.cc File chrome/browser/chromeos/gdata/gdata_util.cc (right): https://chromiumcodereview.appspot.com/10536065/diff/1/chrome/browser/chromeos/gdata/gdata_util.cc#newcode244 chrome/browser/chromeos/gdata/gdata_util.cc:244: ...
8 years, 6 months ago (2012-06-08 01:24:08 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-08 05:16:45 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-08 06:13:57 UTC) #4
hshi1
lgtm
8 years, 6 months ago (2012-06-08 06:16:18 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-08 06:16:27 UTC) #6
hshi1
Satoru -- it looks like CQ still thinks that I am not a committer (or ...
8 years, 6 months ago (2012-06-08 06:17:35 UTC) #7
satorux1
LGTM
8 years, 6 months ago (2012-06-08 14:44:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/10536065/6001
8 years, 6 months ago (2012-06-08 14:44:09 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 17:21:34 UTC) #10
Change committed as 141220

Powered by Google App Engine
This is Rietveld 408576698