Add Javascript time methods to base::Time.

Add Javascript time methods to base::Time.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141317

[Jeffrey Yasskin, 2012-06-07 22:35:07]

I was surprised that there weren't methods to convert directly from javascript
"ms since the epoch" to and from base::Time. It's straightforward to use
FromDoubleT for this purpose, but there's a small risk of typos. In case you're
interested, here are new methods to do it directly.

I didn't map 0 to the null time, but I could do that if you want.

Or if you don't want this API, I don't mind reverting this change.

[brettw, 2012-06-07 22:43:18]

What is the use case for this?

[Jeffrey Yasskin, 2012-06-07 22:51:19]

On 2012/06/07 22:43:18, brettw wrote:
> What is the use case for this?

I'm working on http://crbug.com/122817, where I need to receive an absolute time
from JS. We've decided to take ms-since-epoch there, and internally I'd like to
convert it to a base::Time. (The existing code for relative offsets uses
Time::Now() and TimeDeltas:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/extensions/...)

There's also existing code at
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/extensions/...
that it would make sense to convert.

[Jeffrey Yasskin, 2012-06-08 19:20:16]

http://codereview.chromium.org/10536061/diff/1/base/time.cc
File base/time.cc (right):

http://codereview.chromium.org/10536061/diff/1/base/time.cc#newcode92
base/time.cc:92: if (us_ == 0) {
It may actually make sense to CHECK(!is_null()) here, since JS time doesn't have
an invalid value to map null to. Let me know if you want me to do that instead.

[brettw, 2012-06-08 21:06:50]

lgtm

[commit-bot: I haz the power, 2012-06-08 21:14:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/10536061/1

[commit-bot: I haz the power, 2012-06-08 22:59:35]

Change committed as 141317