Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 10536058: TabContentsWrapper -> TabContents, part 6. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 6. Automation. BUG=131026 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141127

Patch Set 1 #

Patch Set 2 : compile #

Patch Set 3 : GetOwningTabContentsForWebContents #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -126 lines) Patch
M chrome/browser/automation/automation_misc_browsertest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 13 chunks +22 lines, -23 lines 1 comment Download
M chrome/browser/automation/automation_provider_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_util.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 31 chunks +46 lines, -50 lines 0 comments Download
M chrome/browser/external_tab/external_tab_container_win.h View 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/external_tab/external_tab_container_win.cc View 1 2 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-07 20:36:35 UTC) #1
jam
lgtm
8 years, 6 months ago (2012-06-07 21:38:49 UTC) #2
jam
http://codereview.chromium.org/10536058/diff/9001/chrome/browser/automation/automation_provider_observers.cc File chrome/browser/automation/automation_provider_observers.cc (right): http://codereview.chromium.org/10536058/diff/9001/chrome/browser/automation/automation_provider_observers.cc#newcode804 chrome/browser/automation/automation_provider_observers.cc:804: TabContents* tab = TabContents::GetOwningTabContentsForWebContents( nit: i do wonder if ...
8 years, 6 months ago (2012-06-07 21:39:20 UTC) #3
Avi (use Gerrit)
Hm. That's simpler... Hell, why not. I'm rewriting everything.
8 years, 6 months ago (2012-06-07 21:47:59 UTC) #4
jam
sorry I didn't see it earlier :) I think this is also more like existing ...
8 years, 6 months ago (2012-06-07 21:57:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10536058/9001
8 years, 6 months ago (2012-06-07 22:18:24 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 00:17:17 UTC) #7
Change committed as 141127

Powered by Google App Engine
This is Rietveld 408576698