sandbox/linux/seccomp-bpf/verifier.cc - Issue 10536048: Instead of outputting one BPF check per possible system call. Coalesce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf/verifier.cc

Issue 10536048: Instead of outputting one BPF check per possible system call. Coalesce (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Does this result in easier-to-read diffs? Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/seccomp-bpf/verifier.cc

diff --git a/sandbox/linux/seccomp-bpf/verifier.cc b/sandbox/linux/seccomp-bpf/verifier.cc

index ed97572e5b3cf4ad23bfb670058de73e3a94e378..912f53db78f97ffd1b8009f99a870ec27f2fe0f3 100644

--- a/sandbox/linux/seccomp-bpf/verifier.cc

+++ b/sandbox/linux/seccomp-bpf/verifier.cc

@@ -16,7 +16,7 @@ bool Verifier::verifyBPF(const std::vector<struct sock_filter>& program,

return false;

}

Sandbox::EvaluateSyscall evaluateSyscall = evaluators.begin()->first;

- for (int nr = MIN_SYSCALL-1; nr <= MAX_SYSCALL+1; ++nr) {

+ for (int nr = MIN_SYSCALL-1; nr <= static_cast<int>(MAX_SYSCALL)+1; ++nr) {

// We ideally want to iterate over the full system call range and values

// just above and just below this range. This gives us the full result set

// of the "evaluators".