Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5487)

Unified Diff: chrome/browser/resources/options2/cookies_list.js

Issue 10536017: Refactoring CookiesTreeModel to support multiple data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for commes by James and Evan. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/local_data_container.cc ('k') | chrome/browser/resources/options2/cookies_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/cookies_list.js
diff --git a/chrome/browser/resources/options2/cookies_list.js b/chrome/browser/resources/options2/cookies_list.js
index 8a4ae577c02f4d747b0f37eddc89e8d827ab04ff..2db5d87e1f250c5ad77c88e1b69f80cb7e787df6 100644
--- a/chrome/browser/resources/options2/cookies_list.js
+++ b/chrome/browser/resources/options2/cookies_list.js
@@ -605,6 +605,11 @@ cr.define('options', function() {
var parent = this.parent;
if (parent && parent instanceof CookieTreeNode)
return parent.pathId + ',' + this.data.id;
+ // TODO(nasko): until the code is modified to account for the "app" level
+ // in the tree model, use this hack of adding the root node id.
+ if ($('cookies-list').rootId)
+ return $('cookies-list').rootId + ',' + this.data.id;
+
return this.data.id;
},
};
@@ -826,8 +831,15 @@ cr.define('options', function() {
*/
removeByParentId: function(parentId, start, count) {
var parent = parentId ? parentLookup[parentId] : this;
- if (!parent)
- return;
+ if (!parent) {
+ // TODO(nasko): Remove this once the "app" level in the tree model is
+ // accounted for.
+ if (parentId) {
+ parent = this;
+ } else {
+ return;
+ }
+ }
parent.startBatchUpdates();
while (count-- > 0)
@@ -847,8 +859,15 @@ cr.define('options', function() {
if (parentId)
delete lookupRequests[parentId];
var parent = parentId ? parentLookup[parentId] : this;
- if (!parent)
- return;
+ // TODO(nasko): Remove this once the "app" level in the tree model is
+ // accounted for.
+ if (!parent) {
+ if (parentId) {
+ parent = this;
+ } else {
+ return;
+ }
+ }
parent.startBatchUpdates();
parent.clear();
« no previous file with comments | « chrome/browser/local_data_container.cc ('k') | chrome/browser/resources/options2/cookies_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698