Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 10536009: Linux: bump the setuid sandbox API number (Closed)

Created:
8 years, 6 months ago by jln (very slow on Chromium)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, erikwright (departed), agl, jln+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Linux: bump the setuid sandbox API number With this change, the setuid sandbox and the Zygote will start complaining if they expect different API versions. Users will get warning messages if their setuid sandbox is too old and be referred to: https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/linux_util.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/suid/sandbox.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
Brad, let's do it now? Justin, can you approve as owner of /sandbox ? Mark, ...
8 years, 6 months ago (2012-06-05 18:24:41 UTC) #1
jschuh
lgtm
8 years, 6 months ago (2012-06-05 18:28:02 UTC) #2
Mark Mentovai
LGTM for base OWNERS approval.
8 years, 6 months ago (2012-06-05 18:31:30 UTC) #3
Brad Chen
LGTM
8 years, 6 months ago (2012-06-05 19:28:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10536009/1
8 years, 6 months ago (2012-06-05 19:50:52 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-05 21:05:12 UTC) #6
Change committed as 140613

Powered by Google App Engine
This is Rietveld 408576698