Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: vm/intermediate_language_ia32.cc

Issue 10535180: Allow implicit 'close your eyes' of native methods. This will hopefully fix issue 3466. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/intermediate_language_ia32.cc
===================================================================
--- vm/intermediate_language_ia32.cc (revision 8699)
+++ vm/intermediate_language_ia32.cc (working copy)
@@ -480,14 +480,18 @@
// Push the result place holder initialized to NULL.
__ PushObject(Object::ZoneHandle());
// Pass a pointer to the first argument in EAX.
- if (!has_optional_parameters()) {
- __ leal(EAX, Address(EBP, (1 + argument_count()) * kWordSize));
+ intptr_t arg_count = argument_count();
+ if (is_implicit_native_closure()) {
+ arg_count += 1;
+ }
+ if (!has_optional_parameters() && !is_implicit_native_closure()) {
+ __ leal(EAX, Address(EBP, (1 + arg_count) * kWordSize));
} else {
__ leal(EAX,
Address(EBP, ParsedFunction::kFirstLocalSlotIndex * kWordSize));
}
__ movl(ECX, Immediate(reinterpret_cast<uword>(native_c_function())));
- __ movl(EDX, Immediate(argument_count()));
+ __ movl(EDX, Immediate(arg_count));
compiler->GenerateCall(token_index(),
try_index(),
&StubCode::CallNativeCFunctionLabel(),

Powered by Google App Engine
This is Rietveld 408576698