Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: vm/ast.h

Issue 10535180: Allow implicit 'close your eyes' of native methods. This will hopefully fix issue 3466. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/code_generator_ia32.cc » ('j') | vm/code_generator_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/ast.h
===================================================================
--- vm/ast.h (revision 8699)
+++ vm/ast.h (working copy)
@@ -1493,12 +1493,14 @@
const String& native_c_function_name,
NativeFunction native_c_function,
int argument_count,
- bool has_optional_parameters)
+ bool has_optional_parameters,
+ bool is_implicit_native_closure)
regis 2012/06/15 17:13:34 You could drop "implicit", since there is no way o
siva 2012/06/16 00:25:43 I named it is_native_instance_closure On 2012/06/
: AstNode(token_index),
native_c_function_name_(native_c_function_name),
native_c_function_(native_c_function),
argument_count_(argument_count),
- has_optional_parameters_(has_optional_parameters) {
+ has_optional_parameters_(has_optional_parameters),
+ is_implicit_native_closure_(is_implicit_native_closure) {
ASSERT(native_c_function_ != NULL);
ASSERT(native_c_function_name_.IsZoneHandle());
ASSERT(native_c_function_name_.IsSymbol());
@@ -1512,6 +1514,9 @@
bool has_optional_parameters() const {
return has_optional_parameters_;
}
+ bool is_implicit_native_closure() const {
+ return is_implicit_native_closure_;
+ }
virtual void VisitChildren(AstNodeVisitor* visitor) const { }
@@ -1522,6 +1527,7 @@
NativeFunction native_c_function_; // Actual non-Dart implementation.
const int argument_count_; // Native Dart function argument count.
const bool has_optional_parameters_; // Native Dart function kind.
+ const bool is_implicit_native_closure_; // An implicit native closure.
DISALLOW_IMPLICIT_CONSTRUCTORS(NativeBodyNode);
};
« no previous file with comments | « no previous file | vm/code_generator_ia32.cc » ('j') | vm/code_generator_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698