Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10535162: Omit -w from ASan CFLAGS and fix a warning. (Closed)

Created:
8 years, 6 months ago by eugenis
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Omit -w from ASan CFLAGS and fix a warning. BUG=None TEST=nothing breaks TBR=cevans@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142151

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/common.gypi View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evgeniy Stepanov
8 years, 6 months ago (2012-06-14 13:43:54 UTC) #1
Alexander Potapenko
https://chromiumcodereview.appspot.com/10535162/diff/6001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10535162/diff/6001/build/common.gypi#newcode2688 build/common.gypi:2688: '-w', Please remove -w from here as well. https://chromiumcodereview.appspot.com/10535162/diff/6001/content/zygote/zygote_main_linux.cc ...
8 years, 6 months ago (2012-06-14 13:49:59 UTC) #2
Evgeniy Stepanov
https://chromiumcodereview.appspot.com/10535162/diff/6001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10535162/diff/6001/build/common.gypi#newcode2688 build/common.gypi:2688: '-w', On 2012/06/14 13:49:59, Alexander Potapenko wrote: > Please ...
8 years, 6 months ago (2012-06-14 13:53:51 UTC) #3
Alexander Potapenko
LGTM I'll be watching Mac/CrOS ASan bots, assuming Linux works already.
8 years, 6 months ago (2012-06-14 13:56:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/10535162/5006
8 years, 6 months ago (2012-06-14 14:04:30 UTC) #5
commit-bot: I haz the power
Presubmit check for 10535162-5006 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-14 14:04:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/10535162/5006
8 years, 6 months ago (2012-06-14 14:05:50 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-14 16:11:06 UTC) #8 
Change committed as 142151

Powered by Google App Engine
This is Rietveld 408576698