Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 10535141: Cleanup: Move some const char definitions to the .cc file. (try 2) (Closed)

Created:
8 years, 6 months ago by Lei Zhang
Modified:
8 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Cleanup: Move some const char definitions to the .cc file. (try 2) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M base/linux_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/linux_util.cc View 5 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Added BASE_EXPORT this time.
8 years, 6 months ago (2012-06-13 18:24:11 UTC) #1
brettw
lgtm
8 years, 6 months ago (2012-06-13 21:53:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10535141/1
8 years, 6 months ago (2012-06-13 21:58:54 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 23:20:10 UTC) #4
Change committed as 142013

Powered by Google App Engine
This is Rietveld 408576698