Add WebUI::GetDeviceScale

Moves GetIconScaleFactor to WebUI::GetRendererScale in order to reuse code as many places in the C++ code push images to Javascript.

Bug=133032
Test=Compiles

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142499

[Evan Stade, 2012-06-14 22:03:23]

you'll also need a reviewer for content/

http://codereview.chromium.org/10535134/diff/2001/content/public/browser/web_...
File content/public/browser/web_ui.h (right):

http://codereview.chromium.org/10535134/diff/2001/content/public/browser/web_...
content/public/browser/web_ui.h:57: // Javascript.
reading this comment, I'd assume it returns the zoom factor of the contents, but
I don't think that's what it actually does. Hence it needs a better name and
comment.

[pkotwicz, 2012-06-14 23:14:58]

Renamed to GetDeviceScale which is consistent to what this parameter is called
elsewhere in the Chromium code base.
Some places call this parameter DeviceScaleFactor but those shoud be changed to
DeviceScale

[pkotwicz, 2012-06-14 23:17:11]

I realized my previous comment was a bit vague. This is the naming convention I
believe was decided on:
GetDeviceScale -> float
GetDeviceScaleFactor -> ui::ScaleFactor

[Evan Stade, 2012-06-15 18:28:00]

LGTM

please add BUG= and TEST= fields. I'm sure there must be a bug filed for this,
if not please file one. TEST= should be filled out with a brief description of
how to manually verify the code is working.

http://codereview.chromium.org/10535134/diff/9/content/browser/webui/web_ui_i...
File content/browser/webui/web_ui_impl.cc (right):

http://codereview.chromium.org/10535134/diff/9/content/browser/webui/web_ui_i...
content/browser/webui/web_ui_impl.cc:121: return
content::GetDIPScaleFactor(web_contents_->GetRenderWidgetHostView());
you're already in the content namespace here.

[pkotwicz, 2012-06-15 18:56:11]

sky for OWNERS

[sky, 2012-06-15 21:02:14]

LGTM

[commit-bot: I haz the power, 2012-06-15 21:22:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10535134/12001

[commit-bot: I haz the power, 2012-06-15 21:23:04]

Presubmit check for 10535134-12001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/public/browser

Presubmit checks took 1.6s to calculate.

[Avi (use Gerrit), 2012-06-15 22:20:27]

lgtm