Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chromeos/dbus/sms_client.cc

Issue 10535127: Fix clang compile failure in chromeos::SMSClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/sms_client.cc
diff --git a/chromeos/dbus/sms_client.cc b/chromeos/dbus/sms_client.cc
index d923d8fd5e635fde6add0801349bd0b23e88883b..72df74d13d5f81352e439d2efaceb0027adb75fe 100644
--- a/chromeos/dbus/sms_client.cc
+++ b/chromeos/dbus/sms_client.cc
@@ -52,7 +52,8 @@ class SMSClientImpl : public SMSClient {
void OnGetAll(const GetAllCallback& callback, dbus::Response* response) {
if (!response) {
// Must invoke the callback, even if there is no message.
- callback.Run(base::DictionaryValue());
+ base::DictionaryValue empty_dictionary;
+ callback.Run(empty_dictionary);
return;
}
dbus::MessageReader reader(response);
@@ -60,7 +61,8 @@ class SMSClientImpl : public SMSClient {
base::DictionaryValue* dictionary_value = NULL;
if (!value.get() || !value->GetAsDictionary(&dictionary_value)) {
LOG(WARNING) << "Invalid response: " << response->ToString();
- callback.Run(base::DictionaryValue());
+ base::DictionaryValue empty_dictionary;
+ callback.Run(empty_dictionary);
return;
}
callback.Run(*dictionary_value);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698