Issue 10535126: Eliminate the "clock" icon in the omnibox dropdown. The distinction between this and the globe was…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535126: Eliminate the "clock" icon in the omnibox dropdown. The distinction between this and the globe was… (Closed)

Created:
8 years, 6 months ago by Peter Kasting

Modified:
8 years, 6 months ago

Reviewers:
sky, alcor

CC:
chromium-reviews, James Su, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Eliminate the "clock" icon in the omnibox dropdown. The distinction between this and the globe was never clear to users, so let's just simplify. BUG=124450 TEST=A dropdown result that comes from matching the user's typing against the page title should have a globe icon. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141614

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -19 lines)			Patch
D	chrome/app/theme/default_100_percent/omnibox_history.png	View	Binary file		0 comments	Download
D	chrome/app/theme/default_100_percent/omnibox_history_dark.png	View	Binary file		0 comments	Download
D	chrome/app/theme/default_100_percent/omnibox_history_selected.png	View	Binary file		0 comments	Download
D	chrome/app/theme/omnibox_history.pdf	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages