Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/search_engines/template_url_prepopulate_data.h

Issue 10535125: Move the query to the start of the Google search URL in hopes of being slightly more user-friendly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search_engines/template_url_prepopulate_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_prepopulate_data.h
===================================================================
--- chrome/browser/search_engines/template_url_prepopulate_data.h (revision 141606)
+++ chrome/browser/search_engines/template_url_prepopulate_data.h (working copy)
@@ -43,17 +43,11 @@
// not used.
TemplateURL* GetPrepopulatedDefaultSearch(Profile* profile);
-// Both the next two functions use same-origin checks unless the |url| is a
-// Google seach URL, in which case we'll identify any valid Google hostname, or
-// the unsubstituted Google prepopulate URL, as "Google".
-
-// Returns the short name for the matching engine, or url.host() if no engines
-// match. If no engines match and the |url| can't be converted to a valid GURL,
-// returns the string in IDS_UNKNOWN_SEARCH_ENGINE_NAME.
-string16 GetEngineName(const std::string& url);
-
// Returns the type of the matching engine, or SEARCH_ENGINE_OTHER if no engines
-// match.
+// match. This uses same-origin checks unless the |url| is a Google seach URL,
+// in which case we'll identify any valid Google hostname as "Google".
+//
+// NOTE: Must be called on the UI thread.
SearchEngineType GetEngineType(const std::string& url);
} // namespace TemplateURLPrepopulateData
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search_engines/template_url_prepopulate_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698