Issue 10535125: Move the query to the start of the Google search URL in hopes of being slightly more user-friendly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535125: Move the query to the start of the Google search URL in hopes of being slightly more user-friendly. (Closed)

Created:
8 years, 6 months ago by Peter Kasting

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move the query to the start of the Google search URL in hopes of being slightly more user-friendly. This also eliminates some dead code and makes the prepopulate engine matcher a bit more flexible. BUG=130020 TEST=Do an omnibox search; the "q=" portion should be the first query param. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141617

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -67 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_prepopulate_data.h	View	1	1 chunk	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_prepopulate_data.cc	View	1	3 chunks	+26 lines, -34 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc	View	1	2 chunks	+6 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages