Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3207)

Unified Diff: chrome/browser/bookmarks/bookmark_model.h

Issue 10535123: bookmarks: Hide some methods from BookmarNode that are not interesting outside to clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_model.h
diff --git a/chrome/browser/bookmarks/bookmark_model.h b/chrome/browser/bookmarks/bookmark_model.h
index 7ec957c2defce53a407a7ce7db7e054e6c3f02a0..7d9bdfb7a13c019bf3fefd44885a167473c321d6 100644
--- a/chrome/browser/bookmarks/bookmark_model.h
+++ b/chrome/browser/bookmarks/bookmark_model.h
@@ -96,25 +96,7 @@ class BookmarkNode : public ui::TreeNode<BookmarkNode> {
bool is_folder() const { return type_ != URL; }
bool is_url() const { return type_ == URL; }
- // Returns the favicon. In nearly all cases you should use the method
- // BookmarkModel::GetFavicon rather than this. BookmarkModel::GetFavicon
- // takes care of loading the favicon if it isn't already loaded, where as
- // this does not.
- const SkBitmap& favicon() const { return favicon_; }
- void set_favicon(const SkBitmap& icon) { favicon_ = icon; }
-
- // The following methods are used by the bookmark model, and are not
- // really useful outside of it.
-
bool is_favicon_loaded() const { return is_favicon_loaded_; }
- void set_is_favicon_loaded(bool loaded) { is_favicon_loaded_ = loaded; }
-
- HistoryService::Handle favicon_load_handle() const {
- return favicon_load_handle_;
- }
- void set_favicon_load_handle(HistoryService::Handle handle) {
- favicon_load_handle_ = handle;
- }
// Accessor method for controlling the visibility of a bookmark node/sub-tree.
// Note that visibility is not propagated down the tree hierarchy so if a
@@ -135,6 +117,18 @@ class BookmarkNode : public ui::TreeNode<BookmarkNode> {
// Called when the favicon becomes invalid.
void InvalidateFavicon();
+ const SkBitmap& favicon() const { return favicon_; }
+ void set_favicon(const SkBitmap& icon) { favicon_ = icon; }
+
+ void set_is_favicon_loaded(bool loaded) { is_favicon_loaded_ = loaded; }
+
+ HistoryService::Handle favicon_load_handle() const {
+ return favicon_load_handle_;
+ }
+ void set_favicon_load_handle(HistoryService::Handle handle) {
+ favicon_load_handle_ = handle;
+ }
+
// The unique identifier for this node.
int64 id_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698