content/browser/download/byte_stream_unittest.cc - Issue 10535116: Submitting ByteStream chrome class for Google C++ Readability Review.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/download/byte_stream_unittest.cc

Issue 10535116: Submitting ByteStream chrome class for Google C++ Readability Review. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a bit of clarifying boilerplate to explanatory usage. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « content/browser/download/byte_stream.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/download/byte_stream.h"	5 #include "content/browser/download/byte_stream.h"

6	6

7 #include <deque>	7 #include <deque>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/callback.h"	10 #include "base/callback.h"

(...skipping 583 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
594	594

595 // Immediately close the stream.	595 // Immediately close the stream.

596 byte_stream_input->Close(content::DOWNLOAD_INTERRUPT_REASON_NONE);	596 byte_stream_input->Close(content::DOWNLOAD_INTERRUPT_REASON_NONE);

597 ::testing::Mock::VerifyAndClearExpectations(task_runner.get());	597 ::testing::Mock::VerifyAndClearExpectations(task_runner.get());

598 EXPECT_CALL(*task_runner.get(), RunsTasksOnCurrentThread())	598 EXPECT_CALL(*task_runner.get(), RunsTasksOnCurrentThread())

599 .WillRepeatedly(Return(true));	599 .WillRepeatedly(Return(true));

600 intermediate_callback.Run();	600 intermediate_callback.Run();

601 EXPECT_EQ(1, num_callbacks);	601 EXPECT_EQ(1, num_callbacks);

602 }	602 }

603	603

604

OLD	NEW