Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10535113: Add dependencies on HistoryService/BookmarkModel. (Closed)

Created:
8 years, 6 months ago by Elliot Glaysher
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), rdsmith+dwatch_chromium.org, akalin
Visibility:
Public.

Description

Add dependencies on HistoryService/BookmarkModel. BUG=97804, 112525 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M chrome/browser/bookmarks/bookmark_model_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Elliot Glaysher
rlp: review others: stamps
8 years, 6 months ago (2012-06-11 21:01:04 UTC) #1
Randy Smith (Not in Mondays)
download_service_factory.cc LGTM.
8 years, 6 months ago (2012-06-11 21:04:26 UTC) #2
rpetterson
LGTM
8 years, 6 months ago (2012-06-11 21:05:46 UTC) #3
tim (not reviewing)
sync/ LGTM
8 years, 6 months ago (2012-06-11 21:25:13 UTC) #4
sky
LGTM
8 years, 6 months ago (2012-06-11 21:30:01 UTC) #5
Paweł Hajdan Jr.
LGTM stamp
8 years, 6 months ago (2012-06-12 06:29:40 UTC) #6
dominich
LGTM++
8 years, 6 months ago (2012-06-12 14:32:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10535113/1
8 years, 6 months ago (2012-06-12 16:33:47 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 17:44:19 UTC) #9
Change committed as 141682

Powered by Google App Engine
This is Rietveld 408576698