Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10535107: Supressing the UNADDRESSABLE ACCESS warning remoting::BreakpadWinDeathTest_TestAccessViolation_Test… (Closed)

Created:
8 years, 6 months ago by alexeypa (please no reviews)
Modified:
8 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Disabling BreakpadWinDeathTest tests when running under Dr. Memory and TSAN. Dr, Memory gets confused about intentional exceptions generated by the tests. TSAN found http://crbug.com/132164 which is baing investigated. In either case the code in question is used by the tests only. BUG=130678, 132164 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141586

Patch Set 1 #

Patch Set 2 : Disabling the tests instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/remoting_unittests.gtest-tsan_win32.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alexeypa (please no reviews)
Please take a look.
8 years, 6 months ago (2012-06-11 16:18:00 UTC) #1
Lei Zhang
LGTM If you want to disable the test instead, that's fine too.
8 years, 6 months ago (2012-06-11 18:46:19 UTC) #2
alexeypa (please no reviews)
Please take another look to make sure that I disabled the tests in the right ...
8 years, 6 months ago (2012-06-11 22:46:21 UTC) #3
alexeypa (please no reviews)
Please take another look to make sure that I disabled the tests in the right ...
8 years, 6 months ago (2012-06-11 22:46:21 UTC) #4
Lei Zhang
lgtm
8 years, 6 months ago (2012-06-11 22:50:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10535107/3001
8 years, 6 months ago (2012-06-11 23:25:51 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 01:28:50 UTC) #7
Change committed as 141586

Powered by Google App Engine
This is Rietveld 408576698