Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 10535106: Fix presubmit check to account for e.g. fooblat_unittest_android.cc (Closed)

Created:
8 years, 6 months ago by Jói
Modified:
8 years, 6 months ago
Reviewers:
bryeung, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Fix presubmit check to account for e.g. fooblat_unittest_android.cc being allowed to call test-only code. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jói
8 years, 6 months ago (2012-06-11 15:17:02 UTC) #1
bryeung
lgtm
8 years, 6 months ago (2012-06-11 15:20:05 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-11 15:22:48 UTC) #3
Jói
maruel: Please take a look.
8 years, 6 months ago (2012-06-11 15:23:15 UTC) #4
M-A Ruel
lgtm
8 years, 6 months ago (2012-06-11 15:33:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10535106/1
8 years, 6 months ago (2012-06-11 22:33:57 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-11 23:30:12 UTC) #7
Change committed as 141558

Powered by Google App Engine
This is Rietveld 408576698