Implement heap profiler memory usage reporting.

Implement heap profiler memory usage reporting.

Committed: https://code.google.com/p/v8/source/detail?r=11793

[mnaganov (inactive), 2012-06-11 09:47:19]

https://chromiumcodereview.appspot.com/10535096/diff/1/include/v8-profiler.h
File include/v8-profiler.h (right):

https://chromiumcodereview.appspot.com/10535096/diff/1/include/v8-profiler.h#...
include/v8-profiler.h:487: static size_t GetUsedMemorySize();
The name isn't very clear. How about GetMemorySizeUsedByProfiler?

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator....
src/profile-generator.cc:1548: size_t size = sizeof(*this);
I think we need to mention in declarations of all these classes that after
adding a new field one needs to update the corresponding size-calculating
functions.

[loislo, 2012-06-11 09:59:20]

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator....
src/profile-generator.cc:1548: size_t size = sizeof(*this);
On 2012/06/11 09:47:19, Mikhail Naganov (Chromium) wrote:
> I think we need to mention in declarations of all these classes that after
> adding a new field one needs to update the corresponding size-calculating
> functions.

2 alexeif: please provide a run-time assert or even compile time assert for the
case when someone added a member and don't declared it in a members list. It'd
be something like sizeof(this) == MembersSize()

[mnaganov (inactive), 2012-06-11 10:01:55]

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator....
src/profile-generator.cc:1548: size_t size = sizeof(*this);
On 2012/06/11 09:59:20, loislo wrote:
> On 2012/06/11 09:47:19, Mikhail Naganov (Chromium) wrote:
> > I think we need to mention in declarations of all these classes that after
> > adding a new field one needs to update the corresponding size-calculating
> > functions.
> 
> 2 alexeif: please provide a run-time assert or even compile time assert for
the
> case when someone added a member and don't declared it in a members list. It'd
> be something like sizeof(this) == MembersSize()

Compile-time assert is preferred.

[alf, 2012-06-12 17:51:28]

https://chromiumcodereview.appspot.com/10535096/diff/1/include/v8-profiler.h
File include/v8-profiler.h (right):

https://chromiumcodereview.appspot.com/10535096/diff/1/include/v8-profiler.h#...
include/v8-profiler.h:487: static size_t GetUsedMemorySize();
On 2012/06/11 09:47:19, Mikhail Naganov (Chromium) wrote:
> The name isn't very clear. How about GetMemorySizeUsedByProfiler?

Done.

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10535096/diff/1/src/profile-generator....
src/profile-generator.cc:1548: size_t size = sizeof(*this);
On 2012/06/11 10:01:55, Mikhail Naganov (Chromium) wrote:
> On 2012/06/11 09:59:20, loislo wrote:
> > On 2012/06/11 09:47:19, Mikhail Naganov (Chromium) wrote:
> > > I think we need to mention in declarations of all these classes that after
> > > adding a new field one needs to update the corresponding size-calculating
> > > functions.
> > 
> > 2 alexeif: please provide a run-time assert or even compile time assert for
> the
> > case when someone added a member and don't declared it in a members list.
It'd
> > be something like sizeof(this) == MembersSize()
> 
> Compile-time assert is preferred.

Done.

[mnaganov (inactive), 2012-06-12 21:43:26]

LGTM with a comment

https://chromiumcodereview.appspot.com/10535096/diff/6001/src/profile-generat...
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10535096/diff/6001/src/profile-generat...
src/profile-generator.cc:1264: STATIC_CHECK(sizeof(HeapSnapshot) ==
Please verify that this statement passes presubmit check. The C++ style guide
advices against getting sizeofs for types.

[alexeif, 2012-06-13 10:47:20]

PTAL

https://chromiumcodereview.appspot.com/10535096/diff/6001/src/profile-generat...
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10535096/diff/6001/src/profile-generat...
src/profile-generator.cc:1264: STATIC_CHECK(sizeof(HeapSnapshot) ==
On 2012/06/12 21:43:26, Mikhail Naganov (Chromium) wrote:
> Please verify that this statement passes presubmit check. The C++ style guide
> advices against getting sizeofs for types.
yes, it passes, but I decided to change it to be conformant to the C++ guide.

[mnaganov (inactive), 2012-06-13 10:56:46]

lgtm

[yurys, 2012-06-18 07:28:28]

https://chromiumcodereview.appspot.com/10535096/diff/13001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://chromiumcodereview.appspot.com/10535096/diff/13001/include/v8-profile...
include/v8-profiler.h:487: static size_t GetMemorySizeUsedByProfiler();
nit: I would include units into the name: GetMemoryUsedByProfilerInBytes