Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10535084: Coverity: Remove dead code. (Closed)

Created:
8 years, 6 months ago by kmadhusu
Modified:
8 years, 6 months ago
Reviewers:
mrossetti, Mark P, sky
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Coverity: Remove dead code. Remove logically dead code. The value of "term_score" in the else block is between 10 and 29, therefore, the condition "term_score <=30" cannot be false. CID=104184. BUG=none TEST=none TBR=sky@chromium.org,mpearson@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/history/scored_history_match.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kmadhusu
8 years, 6 months ago (2012-06-08 19:42:20 UTC) #1
mrossetti
- mrossetti + mpearson
8 years, 6 months ago (2012-06-11 15:11:53 UTC) #2
mrossetti
lgtm
8 years, 6 months ago (2012-06-11 15:12:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10535084/1
8 years, 6 months ago (2012-06-12 17:37:59 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 19:39:07 UTC) #5
Change committed as 141709

Powered by Google App Engine
This is Rietveld 408576698