skia.gyp: use VS2010 provided stdint header

skia.gyp: use VS2010 provided stdint header

Visual Studio 2010 provides its own copy of stdint.h which is
more complete than the skia copy in skia/config/win/stdint.h.
Third-party code might be surprised when compiling under VS2010
to have

  #include <stdint.h>

not be the VS2010 provided version.

BUG=
TEST=

[jaysoffian, 2012-06-08 19:52:21]

@alexeypa: copied you for your opinion whether 2010 express will be happy with
this.

[Nico, 2012-06-08 19:59:01]

I'm fine with this if the skia folks (== epoger :-) ) think it's ok.

[jaysoffian, 2012-06-08 20:10:55]

Drat. It turns out there's other gyp files which also include their own stdint.h
(third_party/leveldatabase, but there may be others too). I may as well fix this
for all of them at once. I'll add a win_has_stdint or some such to common.gypi
and then reference that in the other GYPs.

[Nico, 2012-06-08 20:16:42]

+scottmg

Scott, see above "drat" comment. Sounds like the right direction to me, but if
you object, maybe do it now before Jay does it :-)

[jaysoffian, 2012-06-08 22:32:53]

This turns out to be a pain to fix. stdint.h is sprinkled into over a
half-dozen locations in the source tree, with some of those copies
being brought in via DEPS and in some cases into directories that have
other compatibility headers besides stdint.h.

So a proper fix would be to have a single compatibility stdint.h
somewhere in the source tree, and add the include path to that copy
only on Windows with MSVS < 2010. Then the stdint.h's in all the other
locations would need to be removed. For reference:

ppapi/generators/test_cgen/stdint.h
sdch/open-vcdiff/vsprojects/stdint.h
skia/config/win/stdint.h
third_party/ffmpeg/chromium/include/win/stdint.h
third_party/leveldatabase/src/port/win/stdint.h
third_party/libusb/src/msvc/stdint.h
third_party/WebKit/Source/JavaScriptCore/os-win32/stdint.h
third_party/yasm/source/config/win/stdint.h

(The one inside WebKit may or may not matter, not sure.)

If this has a likelihood of being accepted, I'll work on a patch.
Otherwise I'll find another solution for my use case, which is
specific to RockMelt.

[alexeypa (please no reviews), 2012-06-09 04:42:39]

On 2012/06/08 19:52:21, jaysoffian wrote:
> @alexeypa: copied you for your opinion whether 2010 express will be happy with
> this.

I'm pretty sure stdint.h from VS 2010 and VS 2010 Express are identical.  This
fix should work just fine. I'll can try building the patch in my environment to
verify if you'd like.

[Peter Kasting, 2012-06-09 04:57:21]

On 2012/06/08 22:32:53, jaysoffian wrote:
> If this has a likelihood of being accepted, I'll work on a patch.

I would love to see such a patch.  It would presumably make eliminating our own
stdint.h very easy if at some point we can drop support for MSVC < 2010.

[scottmg, 2012-06-11 16:48:11]

On 2012/06/08 20:16:42, Nico wrote:
> +scottmg
> 
> Scott, see above "drat" comment. Sounds like the right direction to me, but if
> you object, maybe do it now before Jay does it :-)

win_has_stdint seems fine to me. I'd rather just drop 2008, but I guess that
still has to wait.