/C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

remoting/host/breakpad.h

Index: remoting/host/breakpad.h
diff --git a/remoting/host/breakpad.h b/remoting/host/breakpad.h
new file mode 100644
index 0000000000000000000000000000000000000000..bd13b98df524d57531d60e1ef3ae5ac0e3624d73
--- /dev/null
+++ b/remoting/host/breakpad.h
@@ -0,0 +1,15 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_BREAKPAD_H_
+#define REMOTING_HOST_BREAKPAD_H_

[Peter Kasting, 2012/06/14 20:16:27]

I'm not a big fan of having two headers named identically in parallel
subdirectories.  Not only is it confusing which one to use, but this makes it
harder to e.g. "open breakpad.h" in the Visual Studio command prompt and get the
right one.

Can we combine these into one header, or rename them and make it clear why they
should be separate?

(The same goes for breakpad_win.cc.)

[alexeypa (please no reviews), 2012/06/15 18:45:49]

Agree. It makes sense to rename host/breakpad*.* into
host/usage_stats_consent*.*. Note that there is a later CL that renames
CrashReporting into UsageStats for consistency reasons.

There is also a similar issue with constants.* which is going to be consolidated
by a separate CL.

+
+namespace remoting {
+
+// Returns true if the user has agreed to crash dump collection and uploading.
+bool IsCrashReportingEnabled();
+
+}  // remoting
+
+#endif  // REMOTING_HOST_BREAKPAD_H_