/C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

remoting/host/elevated_controller_module_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <atlbase.h>
 #include <atlcom.h>
 #include <atlctl.h>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/logging.h"
+#include "remoting/base/breakpad.h"
 #include "remoting/host/branding.h"
+#include "remoting/host/breakpad.h"
 
 // MIDL-generated declarations.
 #include "remoting/host/elevated_controller.h"
 
 namespace remoting {
 
 class ElevatedControllerModuleWin
     : public ATL::CAtlExeModuleT<ElevatedControllerModuleWin> {
  public:
   DECLARE_LIBID(LIBID_ChromotingElevatedControllerLib)
 };
 
 } // namespace remoting
 
 
 remoting::ElevatedControllerModuleWin _AtlModule;
 
 int WINAPI WinMain(HINSTANCE instance, HINSTANCE, LPSTR, int command) {
+  // Initializes the crash dump reports.

[Peter Kasting, 2012/06/14 20:16:27]

Nit: This comment doesn't add anything to the code.  Just remove it.

[alexeypa (please no reviews), 2012/06/15 18:45:49]

Done.

+  if (remoting::IsCrashReportingEnabled()) {
+    remoting::InitializeCrashReporting();
+  }
+
   CommandLine::Init(0, NULL);
 
   // Register and initialize common controls.
   INITCOMMONCONTROLSEX info;
   info.dwSize = sizeof(info);
   info.dwICC = ICC_STANDARD_CLASSES;
   InitCommonControlsEx(&info);
 
   // This object instance is required by Chrome code (for example,
   // FilePath, LazyInstance, MessageLoop).
   base::AtExitManager exit_manager;
 
   // Write logs to the application profile directory.
   FilePath debug_log = remoting::GetConfigDir().
       Append(FILE_PATH_LITERAL("debug.log"));
   InitLogging(debug_log.value().c_str(),
               logging::LOG_ONLY_TO_FILE,
               logging::DONT_LOCK_LOG_FILE,
               logging::APPEND_TO_OLD_LOG_FILE,
               logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
 
   return _AtlModule.WinMain(command);
 }