Enforce compressed texture restrictions

Enforce compressed texture restrictions

TEST=unit tests
BUG=131743
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141292

[greggman, 2012-06-08 05:05:20]

Hey Al, PTAL

Sorry about the SetGLError giant change. I just got tired of all the string
manipulation stuff

[apatrick_chromium, 2012-06-08 18:46:47]

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6798: case
GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
body of switch should be indented 2 spaces.

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6813: const int kBlockWidth = 4;
nit: single definition of kBlockWidth and kBlockHeight in this function.

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6844: const int kBlockWidth = 4;
In fact, why not just have a single constant for DXT block size for the whole
file.

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6849: (level && height == 2) ||
!(height % kBlockHeight);
nit: up to you but you could have a function like IsValidDXTSize.

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6875: case
GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
indent body of switch.

[greggman, 2012-06-08 20:01:13]

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6798: case
GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
On 2012/06/08 18:46:47, apatrick_chromium wrote:
> body of switch should be indented 2 spaces.

Done.

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6844: const int kBlockWidth = 4;
On 2012/06/08 18:46:47, apatrick_chromium wrote:
> In fact, why not just have a single constant for DXT block size for the whole
> file.

Done.

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6849: (level && height == 2) ||
!(height % kBlockHeight);
On 2012/06/08 18:46:47, apatrick_chromium wrote:
> nit: up to you but you could have a function like IsValidDXTSize.

Done.

http://codereview.chromium.org/10535073/diff/1/gpu/command_buffer/service/gle...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6875: case
GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
On 2012/06/08 18:46:47, apatrick_chromium wrote:
> indent body of switch.

Done.

[apatrick_chromium, 2012-06-08 20:25:03]

lgtm

[commit-bot: I haz the power, 2012-06-08 20:34:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/10535073/8001

[commit-bot: I haz the power, 2012-06-08 21:42:47]

Change committed as 141292