Issue 10535062: Add an asynchronous version of the Flash DeviceID API.

Issue 10535062: Add an asynchronous version of the Flash DeviceID API. (Closed)

Created:
8 years, 6 months ago by brettw

Modified:
8 years, 6 months ago

Reviewers:
raymes

CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an asynchronous version of the Flash DeviceID API. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141486

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : git try #

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+436 lines, -4 lines)			Patch
M	content/browser/renderer_host/pepper_message_filter.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/pepper_message_filter.cc	View		3 chunks	+14 lines, -1 line	0 comments	Download
M	content/ppapi_plugin/ppapi_thread.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/api/private/ppb_flash.idl	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
A	ppapi/api/private/ppb_flash_device_id.idl	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	ppapi/c/private/ppb_flash.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	ppapi/c/private/ppb_flash_device_id.h	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A	ppapi/cpp/private/flash_device_id.h	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
A	ppapi/cpp/private/flash_device_id.cc	View		1 chunk	+45 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_proxy.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_sources.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/proxy/interface_list.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View		2 chunks	+12 lines, -0 lines	0 comments	Download
A	ppapi/proxy/ppb_flash_device_id_proxy.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	ppapi/proxy/ppb_flash_device_id_proxy.cc	View		1 chunk	+126 lines, -0 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ppapi/shared_impl/api_id.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppb_audio_config_shared.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ppapi/shared_impl/resource.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/thunk/interfaces_ppb_private_flash.h	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
A	ppapi/thunk/ppb_flash_device_id_api.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	ppapi/thunk/ppb_flash_device_id_thunk.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	ppapi/thunk/resource_creation_api.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_creation_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_creation_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

raymes

8 years, 6 months ago (2012-06-08 16:49:19 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10535062/diff/2001/ppapi/api/private/p...
File ppapi/api/private/ppb_flash.idl (right):

https://chromiumcodereview.appspot.com/10535062/diff/2001/ppapi/api/private/p...
ppapi/api/private/ppb_flash.idl:182: int32_t GetSettingInt([in] PP_Instance
instance,
Any reason for splitting this line?

https://chromiumcodereview.appspot.com/10535062/diff/2001/ppapi/cpp/private/f...
File ppapi/cpp/private/flash_device_id.h (right):

https://chromiumcodereview.appspot.com/10535062/diff/2001/ppapi/cpp/private/f...
ppapi/cpp/private/flash_device_id.h:19: int32_t GetDeviceID(const
CompletionCallbackWithOutput<Var>& callback);
Should there be a comment about what's returned?

Expand Messages | Collapse Messages