Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 10535061: Clarify the use of --register-chrome-browser-suffix which triggers |unique_suffix| in ShellUtil::Re… (Closed)

Created:
8 years, 6 months ago by gab
Modified:
8 years, 6 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Clarify the use of --register-chrome-browser-suffix which triggers |unique_suffix| in ShellUtil::RegisterChromeBrowser() BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141230

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/installer/util/util_constants.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gab
Baby code review to clarify code I originally found confusing.
8 years, 6 months ago (2012-06-07 19:38:34 UTC) #1
robertshield
lgtm http://codereview.chromium.org/10535061/diff/1/chrome/installer/util/util_constants.cc File chrome/installer/util/util_constants.cc (right): http://codereview.chromium.org/10535061/diff/1/chrome/installer/util/util_constants.cc#newcode110 chrome/installer/util/util_constants.cc:110: // Should only be used by the installer ...
8 years, 6 months ago (2012-06-08 16:04:48 UTC) #2
gab
Done. http://codereview.chromium.org/10535061/diff/1/chrome/installer/util/util_constants.cc File chrome/installer/util/util_constants.cc (right): http://codereview.chromium.org/10535061/diff/1/chrome/installer/util/util_constants.cc#newcode110 chrome/installer/util/util_constants.cc:110: // Should only be used by the installer ...
8 years, 6 months ago (2012-06-08 16:09:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10535061/2002
8 years, 6 months ago (2012-06-08 16:10:34 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 17:35:12 UTC) #5
Change committed as 141230

Powered by Google App Engine
This is Rietveld 408576698