Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 10535049: Try not to inline tcmalloc::Abort() so we can find it in stack trace. (Closed)

Created:
8 years, 6 months ago by kaiwang
Modified:
8 years, 6 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Try not to inline tcmalloc::Abort() so we can find it in stack trace. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141295

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M base/allocator/allocator.gyp View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/base/abort.h View 1 1 chunk +3 lines, -18 lines 0 comments Download
A third_party/tcmalloc/chromium/src/base/abort.cc View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kaiwang
8 years, 6 months ago (2012-06-07 03:35:35 UTC) #1
eroman
lgtm
8 years, 6 months ago (2012-06-07 03:39:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10535049/2002
8 years, 6 months ago (2012-06-07 22:59:47 UTC) #3
commit-bot: I haz the power
Can't process patch for file third_party/tcmalloc/chromium/src/base/abort.cc. Unsupported svn property format.
8 years, 6 months ago (2012-06-07 22:59:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10535049/4004
8 years, 6 months ago (2012-06-07 23:40:48 UTC) #5
commit-bot: I haz the power
Can't process patch for file third_party/tcmalloc/chromium/src/base/abort.cc. Unsupported svn property format.
8 years, 6 months ago (2012-06-07 23:40:48 UTC) #6
jar (doing other things)
IMO... you won't get much value.... ...but you're psyched.... and this does comply with Chromium ...
8 years, 6 months ago (2012-06-08 21:02:31 UTC) #7
kaiwang
8 years, 6 months ago (2012-06-08 21:55:18 UTC) #8
Thanks for your review.
Modified with your suggestions

Powered by Google App Engine
This is Rietveld 408576698