Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 10535045: TabContentsWrapper -> TabContents, for printing code. (Closed)

Created:
8 years, 6 months ago by Lei Zhang
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, for printing code. BUG=131026 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -241 lines) Patch
M chrome/browser/printing/background_printing_manager.h View 4 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 9 chunks +23 lines, -29 lines 0 comments Download
M chrome/browser/printing/print_preview_context_menu_observer.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_preview_context_menu_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.h View 5 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 23 chunks +43 lines, -48 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_browsertest.cc View 7 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 10 chunks +11 lines, -15 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 7 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 18 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 10 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
8 years, 6 months ago (2012-06-07 01:04:18 UTC) #1
Avi (use Gerrit)
Thank you! An unexpected gift. LGTM
8 years, 6 months ago (2012-06-07 14:39:14 UTC) #2
Albert Bodenhamer
lgtm
8 years, 6 months ago (2012-06-07 16:30:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10535045/1
8 years, 6 months ago (2012-06-07 18:35:05 UTC) #4
commit-bot: I haz the power
Try job failure for 10535045-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-07 21:07:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10535045/1
8 years, 6 months ago (2012-06-07 22:20:50 UTC) #6
commit-bot: I haz the power
Try job failure for 10535045-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-08 00:49:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10535045/1
8 years, 6 months ago (2012-06-08 02:28:21 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 03:17:20 UTC) #9
Change committed as 141165

Powered by Google App Engine
This is Rietveld 408576698