Issue 10535041: Log stack trace when ObjectWatcher::StartWatching() is called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535041: Log stack trace when ObjectWatcher::StartWatching() is called. (Closed)

Created:
8 years, 6 months ago by dcheng

Modified:
8 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Log stack trace when ObjectWatcher::StartWatching() is called. Something isn't being cleaned up properly and we're seeing crashes where we call into a destroyed class. BUG=121086 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143251

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	base/win/object_watcher.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	base/win/object_watcher.cc	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dcheng

I pulled down one of the minidumps from the crash server and it seems like ...

8 years, 6 months ago (2012-06-06 23:44:49 UTC) #1

willchan no longer on Chromium

8 years, 6 months ago (2012-06-07 00:09:05 UTC) #2

ObjectWatcher is potentially heavily used, so this is only OK for a canary
release, and please don't keep it in for very long.

LGTM

And feel free to TBR the revert to me.

Expand Messages | Collapse Messages