Issue 10535037: copy_framework_unversioned without install_name_tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535037: copy_framework_unversioned without install_name_tool (Closed)

Created:
8 years, 6 months ago by Mark Mentovai

Modified:
8 years, 6 months ago

Reviewers:
TVL

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Give copy_framework_unversioned an option to make a framework unversioned without running install_name_tool on it. This is necessary now that KeystoneRegistration.framework is signed. install_name_tool would invalidate the signature. Since nothing is linked against KeystoneRegistration.framework, its LC_ID_DYLIB is irrelevant and it can be allowed to remain as-is. BUG=131081 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140818

Patch Set 1 : #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -20 lines)			Patch
	M	build/mac/copy_framework_unversioned.sh	View		2 chunks	+36 lines, -20 lines	1 comment	Download
	M	chrome/chrome_dll.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm https://chromiumcodereview.appspot.com/10535037/diff/2001/build/mac/copy_framework_unversioned.sh File build/mac/copy_framework_unversioned.sh (right): https://chromiumcodereview.appspot.com/10535037/diff/2001/build/mac/copy_framework_unversioned.sh#newcode106 build/mac/copy_framework_unversioned.sh:106: FRAMEWORK_DYLIB="${DESTINATION}/${FRAMEWORK_NAME_NOEXT}" part of me wonders if there is ...

8 years, 6 months ago (2012-06-06 20:00:44 UTC) #2

Mark Mentovai

8 years, 6 months ago (2012-06-06 20:04:22 UTC) #3

I got an error when I tried running install_name_tool on something that had been
signed. The error wasn’t obvious, but it was complaining about not being able to
open/seek/write/close, and perhaps not having enough size to complete the task.

Expand Messages | Collapse Messages